Fix WithLatests() fixup on duplicate keys #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rade
reviewed
Jul 25, 2018
report/map_helpers.go
Outdated
| if m[i-1].key == m[i].key { | ||
| if m[i-1].Timestamp.Before(m[i].Timestamp) { | ||
| m = append(m[:i-1], m[i:]...) | ||
| func (m *StringLatestMap) fixup() { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
The fixup() method was modifying a copy of its input, so you could get duplicate keys in the output. Change it to return the new slice. Thankfully this is rare: in most cases WithLatests() is called with fields that are not duplicates of existing ones.
rade
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fixup()method was modifying a copy of its input, so you could get duplicate keys in the output.Thankfully this is rare: in most cases
WithLatests()is called with fields that are not duplicates of existing ones.Added a test that would have caught it.
I made this PR against the release-1.9 branch so we can make a clean patch release.