rename 'storagesheet' to 'sheet' #3323
Conversation
the client now expects a node shape of `sheet` not `storagesheet` update report.go to reflect this. fixes #3322
|
AFAICT this is effectively a protocol change - new clients are unable to render old reports correctly. Correct? This is particularly harmful in Weave Cloud, where users expect to be able to look back at reports going back as far as 13 months. We have historically avoided making such changes, and when we have done so we typically introduced a report upgrade function that converts old reports to new on the fly. |
|
That is correct. The client changed to only accept 'sheet' not 'storagesheet'. Are you suggesting this would be better handled in the client to accept either 'storagesheet' or 'sheet', or to add a 'report upgrade function'? I can revert this change temporarily until we find a more concrete solution @rade |
|
Added compatibility for old scope reports in ebd6376 |
the client now expects a node shape of
sheetnotstoragesheetupdate report.go to reflect this.
fixes #3322