Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support storagesheet for old scope reports #3324

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

guyfedwards
Copy link
Contributor

Old versions of scope reports use storagesheet as the value for node
shape. This shape is no longer supported in weaveworks-ui-components and
so this commit normalises to sheet for compatibility with old reports.

related #3322

Old versions of scope reports use `storagesheet` as the value for node
shape. This shape is no longer supported in weaveworks-ui-components and
so this commit normalises to `sheet` for compatiblity with old reports.

related #3322
@guyfedwards guyfedwards requested review from satyamz and foot August 22, 2018 14:36
Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guyfedwards guyfedwards merged commit 1eab1d5 into master Aug 23, 2018
@guyfedwards guyfedwards deleted the sheet-storage-node-name-compat branch August 23, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants