Add volume snapshot and clone support #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Sorry I haven't been able to do a review yet; please bear with us. |
|
It's Ok @bboreham 😃 |
qiell
force-pushed
the
volume-snapshot
branch
3 times, most recently
from
cea235c to
fe287a1
Compare
bboreham
approved these changes
Oct 15, 2018
report/topology.go
Outdated
| // GetTag returns the current topology tag, or the default if there isn't one. | ||
| func (t Topology) GetTag() string { | ||
| if t.Tag == "" { | ||
| return None |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
added 5 commits
October 16, 2018 01:04
Tag can be used to specify the sub-shape for the given node. Signed-off-by: Akash Srivastava <akash.srivastava@openebs.io>
- Snapshot is a CRD residing in kubernetes-incubator/external-storage It doesn't have a proper clientset. - A PR for proper clientset is already raised. Until the PR is merged, we are using openebs/k8s-snapshot-client as a snapshot client. Signed-off-by: Akash Srivastava <akash.srivastava@openebs.io>
- Add a new client in probe/kubernetes/client.go which will be used to fetch details of Snapshot CRD - Visualize VolumeSnapshot and VolumeSnapshotData - Add adjacency between PV and VolumeSnapshot - Add adjacency between VolumeSnapshot and VolumeSnapshotData - Add snapshot filter to hide and show snapshots Signed-off-by: Akash Srivastava <akash.srivastava@openebs.io>
Signed-off-by: Akash Srivastava <akash.srivastava@openebs.io>
- Add control on volume snapshot to take clone - Add control on volume snapshot to delete it Signed-off-by: Akash Srivastava <akash.srivastava@openebs.io>
qiell
force-pushed
the
volume-snapshot
branch
from
fe287a1 to
4701c61
Compare
|
Some more questions:
|
|
Hi @bboreham
In the probe logs, we'll see
Yes, we need to add this is RBAC settings. committing changes for RBAC in scope deploy yaml in examples. |
This will add rules to cluster role for k8s snapshot components. These RBAC permissions are required for scope to fetch details about volumesnapshots and volumesnapshotdata resources. Signed-off-by: Akash Srivastava <akash.srivastava@openebs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add volume snapshot and clone support. This PR contains all the requirements stated in #3316 please refer same for the k8s level details related to this change.
Add a field
tagwhich is required for using the new shape for volume snapshot Proposal: Add snapshot & clone support for k8s volumes to Weave Scope #3316 (comment)Show
volume snapshotandvolume snapshot dataAdd control on PVC to take a volume snapshot
Add control on volume snapshot to clone & delete it
fixes: #3316