Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Dockerfiles #3411

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Clean up Dockerfiles #3411

merged 1 commit into from
Nov 6, 2018

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Oct 27, 2018

Changed --update & removing the apk cache to using the --no-cache flag, which just installs the newest version of the packages without caching any information.

Changed ADD to COPY, because they are not archives, which have to be unpacked after adding them. In general it is not encouraged to use ADD for just copying files into the image, because of the overloaded functionality of ADD.

@bboreham bboreham self-assigned this Oct 30, 2018
Copy link
Collaborator

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bboreham bboreham merged commit a5d29a9 into weaveworks:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants