Rename :orgId to :instanceId in metrics graph url #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
approved these changes
Dec 17, 2018
|
What happens if an old client meets a new server? |
- Renames placeholders `:orgId` to `:instanceId` in `--app.metrics-graph` - Adjusts frontend client to use the provided instanceId by its host application (Weave Cloud)
rndstr
force-pushed
the
rename-org-instance
branch
from
1e0c3fe to
f8412c3
Compare
what exactly is client/server in this case? the probe has no play here, the app is given the format as config, and the host (weave cloud for us) of the frontend is passing in |
|
OK, so all the bits that know the name will get reloaded at the same time into the browser, so they will all change at once? |
|
IIRC we traditionally haven't worried about compatibility between f/e and b/e. If something looks broken, a reload should fix it. |
|
@bboreham the thing to note here is that it's currently broken in any case. so there is no need to manage a seamingless migration path. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:orgIdto:instanceIdin--app.metrics-graphapplication (Weave Cloud)