Fix one pod to multiple PVC connection #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
reviewed
Jan 10, 2019
probe/kubernetes/pod.go
Outdated
| if p.VolumeClaimName() != "" { | ||
| latests[VolumeClaim] = p.VolumeClaimName() | ||
| if len(p.VolumeClaimNames()) > 0 { | ||
| latests[VolumeClaim] = strings.Join(p.VolumeClaimNames(), "~p$") |
There was a problem hiding this comment.
"~p$" should be a constant.
And is that necessary and/or sufficient? What are the rules on volume claim names?
There was a problem hiding this comment.
PVC name must consist of lower case alphanumeric characters, - or ., and must start and end with an alphanumeric character.
We can use a single space or any special character to join them.
There was a problem hiding this comment.
OK, can you please add a comment about the rules and put the separator in a const.
I would probably just use , as the separator, if that works, but don't really mind.
There was a problem hiding this comment.
Sure @bboreham, , will work or we can use the ; i.e. ScopeDelim.
Read all the PVC source from a pod spec and add adjacency between the pod and its PVCs. Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
qiell
force-pushed
the
fix/one-pod-multiple-pvc-adjacency
branch
from
b3212dc to
60a1c66
Compare
satyamz
approved these changes
Jan 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read all the PVC source from a pod spec
and add adjacency between the pod and its PVCs.
Signed-off-by: Akash Srivastava akashsrivastava4927@gmail.com
fixes: #3550