Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Webpack 4 #3580

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Upgrade to Webpack 4 #3580

merged 2 commits into from
Mar 26, 2019

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Mar 6, 2019

Some of our node dependencies were quite behind, especially Webpack which was blocking bumping other deps and thus resolving some of the latest security issues. Hopefully after this PR, we'll both be able to resolve the remaining security issues and also get some of the Webpack optimizations for free.

Changes

  • Bumped a couple of deps, most notably Webpack 4 and Babel 7
  • Bumped node v8.4.0 -> v8.9.0 and locked it in .nvmrc file
  • Got rid of the ContrastStyleCompiler webpack plugin in favor of a pure SCSS solution, so the contrast mode should be working also in Weave Cloud again
  • Fixed the schemeCategory10 import issue

Notes

  • The production build of app.js entry point file grew 1.36MB -> 1.8MB - could be for a couple of reasons, but maybe we could address it in a separate issue

@fbarl fbarl self-assigned this Mar 6, 2019
@fbarl fbarl force-pushed the experimental-upgrade-webpack-4 branch 2 times, most recently from 4409933 to 995e524 Compare March 25, 2019 11:00
@fbarl fbarl changed the title [WIP] Upgrade to Webpack 4 Upgrade to Webpack 4 Mar 25, 2019
@fbarl fbarl requested a review from foot March 25, 2019 14:42
@fbarl fbarl force-pushed the experimental-upgrade-webpack-4 branch from 6006eaa to 019ab0f Compare March 26, 2019 11:02
@dholbach
Copy link
Contributor

Thanks for your work on this! It seems to work great.

A few things I noted: Upon startup I see @babel/polyfill is loaded more than once on this page. This is probably not desirable/intended and may have consequences if different versions of the polyfills are applied sequentially. If you do need to load the polyfill more than once, use @babel/polyfill/noConflict instead to bypass the warning. in Firefox console.

yarn build lists these two:

  terminal-app-25212d40fcac7d911c2d.js   1010 KiB       1  [emitted]  [big]  terminal-app
           app-06be00839d294e8cf164.js   1.82 MiB       2  [emitted]  [big]  app

@dholbach
Copy link
Contributor

Also yarn audit seems to be a lot happier.

@foot what do you think?

Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@fbarl fbarl merged commit 909395c into master Mar 26, 2019
@fbarl fbarl deleted the experimental-upgrade-webpack-4 branch March 26, 2019 13:40
@fbarl fbarl mentioned this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants