Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples/k8s RBAC permissions #3595

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Update examples/k8s RBAC permissions #3595

merged 1 commit into from
Apr 15, 2019

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Apr 11, 2019 •
edited
Loading

Fixes #3594 by adding a minimal set of extra permissions.

cc @dholbach

@fbarl fbarl requested a review from satyamz April 11, 2019 14:00
@fbarl fbarl self-assigned this Apr 11, 2019
@dholbach dholbach requested a review from qiell April 12, 2019 06:01
qiell
qiell approved these changes Apr 14, 2019
View reviewed changes
Copy link
Contributor

@qiell qiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Thanks for the PR @fbarl :)

satyamz
satyamz approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@satyamz satyamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!! Thanks @fbarl

@satyamz satyamz merged commit 8a9fc2b into master Apr 15, 2019
@fbarl fbarl deleted the 3594-update-k8s-example-permissions branch April 15, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiell qiell qiell approved these changes

@satyamz satyamz satyamz approved these changes

Assignees

@fbarl fbarl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update RBAC permissions in examples/k8s
3 participants
@fbarl @satyamz @qiell