Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove materialize-css JS dep #3596

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Remove materialize-css JS dep #3596

merged 1 commit into from
Apr 15, 2019

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Apr 11, 2019

We are not using it at all and we've received security warnings for it:

image

@fbarl fbarl requested a review from dholbach April 11, 2019 14:14
@fbarl fbarl self-assigned this Apr 11, 2019
dholbach
dholbach approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@dholbach dholbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one - great find!

@dholbach dholbach merged commit f03f41e into master Apr 15, 2019
@dholbach dholbach deleted the remove-materialize-css-dep branch April 15, 2019 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholbach dholbach dholbach approved these changes

Assignees

@fbarl fbarl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbarl @dholbach