Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce leaks in probe endpoint reporter #3661

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Reduce leaks in probe endpoint reporter #3661

merged 2 commits into from
Aug 16, 2019

Conversation

bboreham
Copy link
Collaborator

Fixes #3645

Restarting the thing every six hours is somewhat heavy-handed, but I couldn't find an underlying cause and this will remove the pain for the users affected.

Also loosen the parameters around ebpf restarts, so we will tend to use ebpf more and conntrack less. Continuation of #3653.

Delay kernel events by up to 0.2ms, to reduce the chance the ebpf
reporter sends them out-of-order, and allow out-of-order events to
happen up to once a minute without giving up on the ebpf reporter.
We observe a slow increase in connections reported, and are unable to
find the root cause, so clear down the data every six hours and start
from a clean sheet.
@bboreham bboreham requested a review from qiell as a code owner August 13, 2019 16:34
Copy link
Contributor

@qiell qiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qiell qiell merged commit 55846db into master Aug 16, 2019
@bboreham bboreham deleted the endpoint-tweaks branch August 19, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of endpoints inside probe can grow over time
2 participants