Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(app): Add a debugging summary function, exposed via http #3686

Merged
merged 4 commits into from
Sep 18, 2019

Conversation

bboreham
Copy link
Collaborator

When someone says they have a performance problem, the first thing I want to know is whether Scope is reporting 26,000 processes on a node, or similar. It's awkward to do that via the raw reports, so I wrote this summarising function you can call via URL /admin/summary

Example output:

pod:183, service:81, deployment:87, daemon_set:8, stateful_set:2, cron_job:5, namespace:14, persistent_volume:3, persistent_volume_claim:4, storage_class:1
ip-172-20-2-197;<host>:endpoint:992, process:369, container:101, container_image:41, host:1, overlay:1
ip-172-20-1-59;<host>:endpoint:266, process:250, container:43, container_image:15, host:1, overlay:1
ip-172-20-3-247;<host>:endpoint:891, process:383, container:107, container_image:43, host:1, overlay:1

Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, left only some minor comments! 👌

One more comment I have is that it would be nice to update some docs with this change, e.g.

report/report.go Outdated Show resolved Hide resolved
report/report.go Outdated Show resolved Hide resolved
app/multitenant/aws_collector.go Show resolved Hide resolved
@bboreham
Copy link
Collaborator Author

Update the Github issue template to paste the output of /admin/summary whenever filing a new bug

I think I will leave this until experience tells us we need the info very often.

@bboreham bboreham merged commit 6ee9738 into master Sep 18, 2019
@bboreham bboreham deleted the analyze-reports branch September 18, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants