Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(app): Add a debugging summary function, exposed via http #3686

Merged
merged 4 commits into from
Sep 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions app/collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ type Reporter interface {
Report(context.Context, time.Time) (report.Report, error)
HasReports(context.Context, time.Time) (bool, error)
HasHistoricReports() bool
AdminSummary(context.Context, time.Time) (string, error)
WaitOn(context.Context, chan struct{})
UnWait(context.Context, chan struct{})
}
Expand Down Expand Up @@ -172,6 +173,20 @@ func (c *collector) HasHistoricReports() bool {
return false
}

// AdminSummary returns a string with some internal information about
// the report, which may be useful to troubleshoot.
func (c *collector) AdminSummary(ctx context.Context, timestamp time.Time) (string, error) {
c.mtx.Lock()
defer c.mtx.Unlock()
var b strings.Builder
for i := range c.reports {
fmt.Fprintf(&b, "%v: ", c.timestamps[i].Format(time.StampMilli))
b.WriteString(c.reports[i].Summary())
b.WriteByte('\n')
}
return b.String(), nil
}

// remove reports older than the app.window
func (c *collector) clean() {
var (
Expand Down Expand Up @@ -240,6 +255,11 @@ func (c StaticCollector) HasHistoricReports() bool {
return false
}

// AdminSummary implements Reporter
func (c StaticCollector) AdminSummary(ctx context.Context, timestamp time.Time) (string, error) {
return "not implemented", nil
}

// Add adds a report to the collector's internal state. It implements Adder.
func (c StaticCollector) Add(context.Context, report.Report, []byte) error { return nil }

Expand Down
29 changes: 29 additions & 0 deletions app/multitenant/aws_collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"fmt"
"io"
"strconv"
"strings"
"sync"
"time"

Expand Down Expand Up @@ -444,6 +445,34 @@ func (c *awsCollector) HasHistoricReports() bool {
return true
}

// AdminSummary returns a string with some internal information about
// the report, which may be useful to troubleshoot.
func (c *awsCollector) AdminSummary(ctx context.Context, timestamp time.Time) (string, error) {
span, ctx := opentracing.StartSpanFromContext(ctx, "awsCollector.Report")
defer span.Finish()
userid, err := c.cfg.UserIDer(ctx)
if err != nil {
return "", err
}
end := timestamp
start := end.Add(-c.cfg.Window)
reportKeys, err := c.getReportKeys(ctx, userid, start, end)
if err != nil {
return "", err
}
reports, err := c.reportsForKeysInRange(ctx, reportKeys, start.UnixNano(), end.UnixNano())
if err != nil {
return "", err
}
var b strings.Builder
for i := range reports {
// TODO: print the key - note reports may be in a different order from reportKeys
bboreham marked this conversation as resolved.
Show resolved Hide resolved
b.WriteString(reports[i].Summary())
b.WriteByte('\n')
}
return b.String(), nil
}

// calculateDynamoKeys generates the row & column keys for Dynamo.
func calculateDynamoKeys(userid string, now time.Time) (string, string) {
rowKey := fmt.Sprintf("%s-%s", userid, strconv.FormatInt(now.UnixNano()/time.Hour.Nanoseconds(), 10))
Expand Down
12 changes: 12 additions & 0 deletions app/router.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,18 @@ func RegisterReportPostHandler(a Adder, router *mux.Router) {
}))
}

// RegisterAdminRoutes registers routes for admin calls with a http mux.
func RegisterAdminRoutes(router *mux.Router, reporter Reporter) {
get := router.Methods("GET").Subrouter()
get.Handle("/admin/summary", requestContextDecorator(func(ctx context.Context, w http.ResponseWriter, r *http.Request) {
summary, err := reporter.AdminSummary(ctx, time.Now())
if err != nil {
respondWith(w, http.StatusBadRequest, err)
}
fmt.Fprintln(w, summary)
}))
}

var newVersion = struct {
sync.Mutex
*xfer.NewVersionInfo
Expand Down
1 change: 1 addition & 0 deletions prog/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ func router(collector app.Collector, controlRouter app.ControlRouter, pipeRouter
app.RegisterControlRoutes(router, controlRouter)
app.RegisterPipeRoutes(router, pipeRouter)
app.RegisterTopologyRoutes(router, app.WebReporter{Reporter: collector, MetricsGraphURL: metricsGraphURL}, capabilities)
app.RegisterAdminRoutes(router, collector)

uiHandler := http.FileServer(GetFS(externalUI))
router.PathPrefix("/ui").Name("static").Handler(
Expand Down
21 changes: 21 additions & 0 deletions report/report.go
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,27 @@ func (r Report) upgradeDNSRecords() Report {
return r
}

// Summary returns a human-readable string summarising the contents, for diagnostic purposes
func (r Report) Summary() string {
ret := ""
if len(r.Host.Nodes) == 1 {
for k := range r.Host.Nodes {
ret = k + ": "
}
}
count := 0
r.WalkNamedTopologies(func(n string, t *Topology) {
if len(t.Nodes) > 0 {
count++
if count > 1 {
ret = ret + ", "
}
ret = ret + fmt.Sprintf("%s:%d", n, len(t.Nodes))
}
})
return ret
}

// Sampling describes how the packet data sources for this report were
// sampled. It can be used to calculate effective sample rates. We can't
// just put the rate here, because that can't be accurately merged. Counts
Expand Down
6 changes: 6 additions & 0 deletions site/faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ Scope doesn't support LDAP right now.

OSS Scope reports aren't persistent and the probe keeps the last 15 seconds of metrics in memory.

## Admin Endpoints

Scope exposes the following http endpoints that can be used for troubleshooting:

- `/admin/summary` - lists the reports being used by the app, with counts of each node type (containers, processes, etc.).

## API Endpoints

Scope exposes the following endpoints that can be used by external monitoring services.
Expand Down