Move Adjacency info inside the NodeMetadata struct #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
changed the title
tomwilkie
force-pushed
the
357-adjacencies-to-nodemetadata
branch
from
bc51be3 to
443e92c
Compare
tomwilkie
changed the title
tomwilkie
force-pushed
the
357-adjacencies-to-nodemetadata
branch
from
443e92c to
c60999f
Compare
…generation to the probes.
tomwilkie
force-pushed
the
357-adjacencies-to-nodemetadata
branch
from
c60999f to
1f6b3d4
Compare
| t.NodeMetadatas[srcNodeID] = srcNode | ||
|
|
||
| if _, ok := t.NodeMetadatas[dstNodeID]; !ok { | ||
| t.NodeMetadatas[dstNodeID] = report.MakeNodeMetadata() |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I didn't look deeply at the tests, but this looks good. Once the constructor thing is taken care of (or an alternate suggestion made) 👍 |
This was referenced Sep 1, 2015
tomwilkie
added a commit
that referenced
this pull request
Sep 1, 2015
Move Adjacency info inside the NodeMetadata struct
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves pseudo node generation to the probes, see #357