Split the internet node for incoming vs outgoing connections.

[tomwilkie]

Fixes #360, includes #570

Before this change:

After this change:

[peterbourgon]

👎

• Two internet nodes in the same graph is immediately confusing
• The heuristic of incoming vs. outgoing connections is nonobvious, nondeterministic, and confuses the codebase
• The "fix" to the rendered topology is superficial; I believe we can get better results by continuing to iterate on the UI

[pidster]

On the basis that the outbound node will be split into labelled services (somehow) and that the two internet nodes are now visibly separate; the two nodes primary label should be "Inbound" and "Outbound" (connections) - not "The Internet" (inbound/outbound).

So reversing the title/subtitle labels in effect.

[tomwilkie]

Screen shot showing outgoing internet lower than other nodes (David's work):

[tomwilkie]

Renamed to "Inbound" / "Outbound" Requests:

As this has been an contentious PR, I'd like to get an LGTM from @pidster for the concept, and a second LGTM from someone (@paul?) for the code.

[paulbellamy]

The code looks fine. Conceptually I'm far from convinced this is a good idea.

• Inbound/Outbound is a complete guess. Right now we have no way of actually telling this.
• the outbound node will be split into labelled services (somehow) I'd like to see a proof-of-concept that this is can be done usefully before we make this the goal.

[pidster]

LGTM

Sorry for the delay.
I think we need to make progress and then iterate based on feedback.

[tomwilkie]

I've rebased this up to date, but the pinning of the internet nodes doesn't seem to be working properly @davkal:

[davkal]

• added JS tests, now for the real world...
• outbound node positioning seems to work
• @tomwilkie got a report with incoming nodes to test?
• still thinking about positioning relative to unconnected node field (which can be big, pushing the out node far below)

[davkal]

This is the unconnected field I'm talking about:

Angry torvalds suddenly appeared (initially unconnected, so it was laid out in the field). Let's see if I do the internet positioning step afterwards.

[davkal]

Seems to work:

Click on Force Re-layout balances layout nicely, too.

[davkal]

Inbound node positioning seems to shift nodes, but leave edges untouched. Fixing that...

[tomwilkie]

@davkal inbound from the internet to the scope container (will need to show them)

report.json.zip

[davkal]

[tomwilkie]

thanks @davkal! I don't know about you, but I don't think the pinning looks that good - this is without the pinning:

[pidster]

I am +1 for splitting The Internet into Outgoing & Incoming per the above.
See also: #1082

I understand that improving the rendering algo that pins the two nodes to the top & bottom respectively, to make a less odd looking diagram will require more work - so let's park that for now.

LGTM without pinning, for now.