Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of probe main #633

Merged
merged 2 commits into from
Nov 9, 2015
Merged

Refactoring of probe main #633

merged 2 commits into from
Nov 9, 2015

Conversation

paulbellamy
Copy link
Contributor

Fixes #537

  • Move probe/main.go to prog/probe/
  • Rename probe/* the 'probe' package
  • Moves resolver.go to xfer/
  • Removed probe/instrumentation.go, not used anywhere
  • An empty StingSet (and IDList) is now nil
  • Move filter tests to filters_test.go

@tomwilkie tomwilkie force-pushed the refactor-probe-main branch from aaf6db2 to 761b83e Compare November 9, 2015 13:30
@tomwilkie tomwilkie self-assigned this Nov 9, 2015
@tomwilkie tomwilkie changed the title Minor refactoring of probe main [WIP] Refactoring of probe main Nov 9, 2015
@tomwilkie tomwilkie force-pushed the refactor-probe-main branch from 761b83e to 409068b Compare November 9, 2015 14:33
@tomwilkie tomwilkie changed the title [WIP] Refactoring of probe main Refactoring of probe main Nov 9, 2015
@tomwilkie tomwilkie removed their assignment Nov 9, 2015
@tomwilkie tomwilkie force-pushed the refactor-probe-main branch from 6326e81 to 0e72509 Compare November 9, 2015 15:38
paulbellamy
paulbellamy reviewed Nov 9, 2015
View reviewed changes
xfer/resolver.go
@@ -1,4 +1,4 @@
package main
package xfer

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@paulbellamy
Copy link
Contributor Author

Let's break out the functional changes (StringSet stuff) from the re-org, just a separate commit would be nice.

@tomwilkie
Copy link
Contributor

+1 will do.

@tomwilkie tomwilkie force-pushed the refactor-probe-main branch from 0e72509 to f76ab26 Compare November 9, 2015 16:23
@tomwilkie tomwilkie force-pushed the refactor-probe-main branch from f76ab26 to a89c0b9 Compare November 9, 2015 16:26
@tomwilkie
Copy link
Contributor

@paulbellamy I think I've addressed your comment(s)

@tomwilkie tomwilkie assigned paulbellamy and unassigned tomwilkie Nov 9, 2015
@paulbellamy
Copy link
Contributor Author

LGTM

tomwilkie added a commit that referenced this pull request Nov 9, 2015
@tomwilkie
Merge pull request #633 from weaveworks/refactor-probe-main
89c4eb1 
Refactoring of probe main
@tomwilkie tomwilkie merged commit 89c4eb1 into master Nov 9, 2015
@tomwilkie tomwilkie deleted the refactor-probe-main branch November 9, 2015 16:47
bboreham added a commit that referenced this pull request Jul 1, 2019
@bboreham
fix: remove unused metric SpyDuration
65eeee5 
The call to register this metric was removed in #633 over three years ago.
If it isn't registered then nobody can see the values.
The measurement is duplicated by metrics added in #658.
@bboreham bboreham mentioned this pull request Jul 1, 2019
Merged
bboreham added a commit that referenced this pull request Jul 4, 2019
@bboreham
fix: remove unused metric SpyDuration
c1e110a 
The call to register this metric was removed in #633 over three years ago.
If it isn't registered then nobody can see the values.
The measurement is duplicated by metrics added in #658.
qiell pushed a commit to mayadata-io/scope that referenced this pull request Jul 5, 2019
@bboreham @qiell
fix: remove unused metric SpyDuration
e8c0e1a 
The call to register this metric was removed in weaveworks#633 over three years ago.
If it isn't registered then nobody can see the values.
The measurement is duplicated by metrics added in weaveworks#658.
satyamz pushed a commit to mayadata-io/scope that referenced this pull request Aug 8, 2019
@qiell @satyamz
Rebase mdap-rc1 with upstream updates (#170)
94bbc66 
* refactor(logs): Add reporter name to error logs.

1. Adding reporter name to logs improves tracing of error.
2. Capitalize first letter of error log.

Fixes weaveworks#3306

Signed-off-by: Prince Rachit Sinha <prince.rachit@mayadata.io>

* fix: handle errors reported by the conntrack package

In particular, ENOBUFS which indicates data has been dropped.
With this change the collector will restart, thus resynchronising with
the OS.

* fix: remove unused metric SpyDuration

The call to register this metric was removed in weaveworks#633 over three years ago.
If it isn't registered then nobody can see the values.
The measurement is duplicated by metrics added in weaveworks#658.

* Defer metrics registration until we need it

This avoids app-specific metrics appearing in the probe.

* docs: Release 1.11.3

* docs: remove mention of long-deprecated boot2docker

* docs: help users to avoid opening their computer to the Internet

* bump_license

* fix(probe): Update tcptracer-bpf package to cure out-of-order events

Avoid ebpf events out of order by adding offset to time.

* Add another warning about exposing on the Internet

* Remove quay.io from release script

* Bold the warning about exposing on the Internet

* Release 1.11.4

* Update with latest changes

* Add OpenEBS CRs clientset

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add SP and Disk Support

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add new sub-topology under Hosts

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update circle-ci from 1.0 to 2.0

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Fix unit tests in render and kubernetes

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update circle-ci config.yaml to install dependencies

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* update circle-ci for image-tag. (#118)

Signed-off-by: Pradeep <pradeepkumar.bk96@gmail.com>

* Add cStor support in Scope

* Add support for CV, CVR & CSP in Scope

* Add proper shapes for CV, CVR & CSP

* Add status field to CV, CVR & CSP

* Remove unnecessary filter in the APITopologyGroup

* Remove unsed PodComponent method

* Filter disk when Show Pods in Volumes

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Fix snapshot filter for show customer resources

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Add node tag and status support

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add unknown state if status is empty (#123)

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add adjacency for the CSP, Disk & SPC

* Add adjacency for the CSP, Disk & SPC

* Fix comments for renderer

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Change favicon.ico and title (#129)

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add adjacency between volumeSnapshot and clonedPVC (#132)

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Read status only once

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Fix UI balnkout issue

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add disk status and creation time in Disk Node

This will also enable the NodeTag for Disk objects.

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Add more details to cv volume (#137)

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Update clientset for disk CR

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add new metadata in disk

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update logic to add adjacency between pod and pvc (#141)

- Adjacency was made just by checking the name of pod claim name
and pvc name, issue is when two pvc in different namespace has same
name.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Remove repititive columns (#144)

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Change log level from warn to debug (#147)

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Remove checkpoint to preserve system info of users (#149) (#150)

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Allow filtering controls on basis of user kind (#153)

* Add support to disable admin controls

This commit will categorize the controls into two types:-
1. Admin Controls (exec, scaleup, scaledown etc.)
2. Read only Controls (logs, describe, attach)

This will add a new flag i.e disableAdminControls
by default, teh value for the above flag will be false,
if value is true, all the admin controls will be disabled.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Read user kind header and filter the controls

This commit will read the header "x-api-user-kind" from request
and check if it is "readAdmin" or not.
If it is the readAdmin, then it will filter all the adminControls
else it will provide all the controls.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Fix table view

* fixed the table view for larger table headers and sidebar issue

* fixes the table header when scrolled

*  Add Block Device support (#162)

* Update openebs clientset to include block device

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update CSP spec to incorporate changes from 0.9 and 1.0

- In 0.9, CSP spec has DiskList but in 1.0 CSP spec has BlockDeviceGroup
To support both add DiskList and Group in CSP spec and update the
clientset of the same.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add Block Device support

This commit will :-
- Visualize Block Device (shape similar to Disk)
- Add Adjacency between BlockDevice and Disk
- Add Adjacency between CSP and BlockDevice only if CSP has block device
list(1.0) otherwise add the adjacency between CSP and Disk(0.9)

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add describe control on block device

This commit will:-
- Add GetBlockDeviceList method to CSP interface.
- Add CaptureBlockDevice method which will be used to fetch the name and
namespace of selected Block Device.
- Add entry of block device in the switch case.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update webpack and package.json

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update ui-components dependency from openebs to mayadata

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* fixes the table header z-index issues

* Update circle ci config (#165)

* Update package.json to exclude building external client

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update circle ci config yaml

- Builds were failing because of ci cache. Update it to use new files
instead of cached ones.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update pvc size to read from status (#166)

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add spec and clientset of bdc

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add adjacency between pv and bdc

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add support to visualize bdc

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paulbellamy paulbellamy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Break up probe.main into smaller, testable functions.
2 participants
@paulbellamy @tomwilkie