Less hacky fix for /%2F bug #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| topologyID := rm.Vars["topology"] | ||
| nodeID := rm.Vars["id"] | ||
| if nodeID == "ws" { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
ugly, but can't think of a better way to do it. |
|
I think this is beyond even my ugliness threshold. @peterbourgon have any suggestions? Otherwise I'll take another stab as bashing it into shape. |
tomwilkie
force-pushed
the
804-f-star-cking-slashes
branch
from
505f39e to
d8b3b3a
Compare
None of the topology view name start with (or contain) a slash, so we won't have this bug.
Have updated and rejigged this a little so its less ugly. Also added a test. @paulbellamy PTAL. |
tomwilkie
force-pushed
the
804-f-star-cking-slashes
branch
from
d8b3b3a to
123c400
Compare
paulbellamy
added a commit
that referenced
this pull request
Jan 14, 2016
Less hacky fix for /%2F bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #804