-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with starting / stopping weave #867
Conversation
8c00a18
to
d4f8eb6
Compare
e1a5125
to
1f75219
Compare
@paulbellamy I'm working through the test breakages, but I think this is ready to be reviewed. I'd really like to get this in before I go off on holiday (Friday) |
return "", err | ||
} | ||
|
||
switch v := addrs[0].(type) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
1f75219
to
4a6a90d
Compare
This doesn't seem to be attributing weave endpoints to containers. It seems to just attribute them to "TheInternet". |
Sweet, you found the bug! On Wednesday, 3 February 2016, Paul Bellamy notifications@github.com
|
Should also use the weave client api: https://github.com/weaveworks/weave/tree/master/api |
6b120fc
to
cda5835
Compare
cf05e54
to
b758d56
Compare
394d3d0
to
10f2f46
Compare
I can't explain why the coverage has dropped so much, all the new code has reasonably good coverage. |
10f2f46
to
4d03e92
Compare
4d03e92
to
7f7d176
Compare
- Run the Weave integrations regardless of if weave is detected. - Make everything backoff and not spam the logs. - Add miekg dns to vendor. - Have the app periodically register with weaveDNS, and the probe do lookups there. - Decide what the local networks are at runtime, not once at startup. - Correctly resolve app ids, fixes #825
7f7d176
to
d4e58b9
Compare
Deal with starting / stopping weave
Fixes #510, fixes #784, fixes #825
A few things rolled up in this:
This has a few nice effects:
weave scope launch --no-app
on every machine andweave scope launch --no-probe
on a few)