Fixes host node/details panel color mismatch #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'label_major' has been changed to 'label' in the details api response. - getNodeColorDark was giving up too early if a rank wasn't provided. The topo diagram which uses getNodeColor will select a color even w/ no rank. Hosts don't have ranks at the mo.
|
Works as advertised, but the
Can we do something about this? |
|
I will do something about this! |
|
No, I am having trouble doing something about this. Its white for my host-nodes! Clear-cache? |
|
It seems like this style happens while react reconciliation gets interrupted by #891 |
foot
added a commit
that referenced
this pull request
Feb 1, 2016
Fixes host node/details panel color mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The topo diagram which uses getNodeColor will select a color even w/
no rank. Hosts don't have ranks at the mo.
Fixes #871