Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force-relayout button #981

Merged
merged 1 commit into from
Feb 24, 2016
Merged

Force-relayout button #981

merged 1 commit into from
Feb 24, 2016

Conversation

davkal
Copy link
Contributor

@davkal davkal commented Feb 18, 2016

screen shot 2016-02-18 at 13 08 45

@foot
Copy link
Contributor

foot commented Feb 18, 2016

Works as advertised!

Doesn't do much most of the time when you click on it. I can see myself clicking on it a lot just to see if it makes the current layout "better" somehow.

Could disable the button when forceLayout is set to true, and move the forceLayout = false to just after the conditional that checks for it... so it only re-activates if there are new nodes. Maybe. Then I would click it once sometime during the session, and then it would be de-activated until a new node came in or I changed topo. So it would reactivate fairly quickly anyway. So this doesn't sound like a worthwhile optimization.

LGTM!

@foot foot assigned davkal and unassigned foot Feb 18, 2016
@davkal
Copy link
Contributor Author

davkal commented Feb 18, 2016

Disabled button until new nodes appear, and added title hint.

@davkal davkal assigned foot and unassigned davkal Feb 18, 2016
@foot
Copy link
Contributor

foot commented Feb 23, 2016

As the button behaviour is a bit unpredictable perhaps just always have it enabled.

@foot foot assigned davkal and unassigned foot Feb 23, 2016
@davkal davkal force-pushed the 863-force-relayout branch from dad18f8 to fdeb999 Compare February 24, 2016 14:54
* new button in footer
* when clicked, forces a relayout that could help with degraded graphs
* sets a store flag that will be unset on next nodes delta update
* fixes #863
@davkal davkal force-pushed the 863-force-relayout branch from fdeb999 to 9dafaef Compare February 24, 2016 14:56
davkal added a commit that referenced this pull request Feb 24, 2016
@davkal davkal merged commit d759e9f into master Feb 24, 2016
@davkal davkal deleted the 863-force-relayout branch February 24, 2016 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crossing lines and immovable bobbles
2 participants