Add middleware for conditional Scope report censoring #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like this approach. Well done! |
foot
approved these changes
Feb 26, 2019
users/client/middleware.go
Outdated
| }); err != nil { | ||
| q := r.URL.Query() | ||
| q.Add("hideCommandLineArguments", "true") | ||
| q.Add("hideEnvironmentVariables", "true") |
There was a problem hiding this comment.
If a malicious user has already included a hideEnvironmentVariables=false in the querystring I wonder how the querystring parsing in scope will handle that.
There was a problem hiding this comment.
Maybe https://golang.org/pkg/net/url/#Values.Set instead!
There was a problem hiding this comment.
Thanks @foot, good catch, I'll use Set instead!
fbarl
force-pushed
the
2477-scope-censor-middleware
branch
from
92008ac to
c32f3e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2477 (comment) as suggested by @foot.
Depends on weaveworks/scope#3571.