Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the shade of grey in use throughout the product #93

Closed
wants to merge 2 commits into from

Conversation

bia
Copy link
Contributor

@bia bia commented Dec 16, 2017

I'd like the background colour of the right side box of the monitor dashboards to match the left side navigation bar colour.

Please correct me if I'm wrong, but I think that we use fafafc far more than f8f8f8?

171212sidebarstandard1

cc @weaveworks/keyboard-orchestra

@bia bia requested a review from jpellizzari December 16, 2017 19:16
@bia bia changed the title Change to the shade of grey in use throughout the product Change the shade of grey in use throughout the product Dec 17, 2017
@dlespiau
Copy link
Contributor

Huum, we noticed that lightgray was already barely visible on some monitors, #65 and this is making it even lighter.

@bia
Copy link
Contributor Author

bia commented Dec 18, 2017

@dlespiau Oh - good to know.
I'm just trying to keep things consistent. In that case we could keep #f8f8f8 and change the flux background, monitor side menu bar, and scope background to match. Does that sound ok?

@dlespiau
Copy link
Contributor

If possible, making it darker would be awesome. But otherwise, yes the darker of the two options is probably a good idea.

@bia
Copy link
Contributor Author

bia commented Dec 18, 2017

Even darker than #f8f8f8?
(let's talk about this in our sync today)

@bia
Copy link
Contributor Author

bia commented Dec 18, 2017

In the KO weekly meeting @dlespiau has agreed to help me to find the lightest grey possible to be differentiated from white on poorly calibrated monitors. Then I will reference that colour from the style guide throughout weavecloud. The assumption is that #f8f8f8 will be best, but I await @dlespiau's confirmation.

@bia
Copy link
Contributor Author

bia commented Dec 28, 2017

We're sticking with #f8f8f8, further changes will be requested in service-ui and scope.

@bia
Copy link
Contributor Author

bia commented Apr 9, 2018

Huum, we noticed that lightgray was already barely visible on some monitors, #65 and this is making it even lighter.

@dlespiau This only matters if it needs to be differentiated from another color (implicit question : which color?)

@rade
Copy link
Member

rade commented Apr 9, 2018

@bia the lack of differentiation was between the background in the right pane of the service resource dashboard (e.g. https://cloud.weave.works/prom/cold-sky-72/dashboard/service-resources) and the general dashboard background.

@bia
Copy link
Contributor Author

bia commented Apr 10, 2018

@rade Right, trying to address exactly this in #167.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants