Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Support running / triggering tests for external contributors' PRs #93

Open
fbarl opened this issue Oct 7, 2019 · 2 comments
Open

Support running / triggering tests for external contributors' PRs #93

fbarl opened this issue Oct 7, 2019 · 2 comments
Labels
build An issue concerning compilation, testing, packaging, distribution tech-debt Unpleasantness that does (or may in future) affect development

Comments

@fbarl
Copy link
Contributor

fbarl commented Oct 7, 2019

In the last couple of days, we've had two PRs (#91 and #92) submitted to this repo for which the CircleCI tests didn't run automatically.

Moreover, there was no easy way for me as a maintainer to trigger the test run so I had to copy the branch and push it to this repo to make CircleCI run the tests.

It would be best if the tests ran seamlessly also for the PRs coming from the forked repos, but a good enough start might be for the maintainers to be able to trigger them manually.

We already have this working in https://github.com/weaveworks/scope, but I'm not sure what needs to be done - maybe @bboreham knows more.

cc @palemtnrider

@fbarl fbarl added the build An issue concerning compilation, testing, packaging, distribution label Oct 7, 2019
@bboreham
Copy link
Contributor

bboreham commented Oct 7, 2019

We don't have it working in Scope.
Kubernetes is the only model I know of, where they have a separate daemon look for a maintainer writing an "ok-to-test" comment on each PR.

@fbarl
Copy link
Contributor Author

fbarl commented Oct 7, 2019

We don't have it working in Scope.

How come I can see the tests in weaveworks/scope#3635 then and when I open them, it says an external contributor triggered them? e.g. https://circleci.com/gh/weaveworks/scope/12605?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link 🤔

@palemtnrider palemtnrider added the tech-debt Unpleasantness that does (or may in future) affect development label Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build An issue concerning compilation, testing, packaging, distribution tech-debt Unpleasantness that does (or may in future) affect development
Projects
None yet
Development

No branches or pull requests

3 participants