Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --root cli option and make basic js api work #453

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Conversation

Timeless0911
Copy link
Collaborator

@Timeless0911 Timeless0911 commented Nov 19, 2024

Summary

  • Add --root CLI param as base dir to load Rslib config file and .env file
  • Use config.root which is default to process.cwd() as base dir to load package.json and tsconfig.json

close: #356
close: #361

Related Links

#456

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit a8747f1
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/673d8b6995d88a0008c563d5
😎 Deploy Preview https://deploy-preview-453--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #453 will not alter performance

Comparing js-api (4ebfeb8) with main (9653e3a)

Summary

✅ 5 untouched benchmarks

@Timeless0911 Timeless0911 marked this pull request as ready for review November 20, 2024 03:59
@Timeless0911
Copy link
Collaborator Author

@binarykitchen I think this PR can solve your issue.

packages/core/src/cli/build.ts Outdated Show resolved Hide resolved
packages/core/src/cli/init.ts Show resolved Hide resolved
fi3ework
fi3ework previously approved these changes Nov 20, 2024
fi3ework
fi3ework previously approved these changes Nov 20, 2024
@Timeless0911 Timeless0911 merged commit db602d2 into main Nov 21, 2024
18 checks passed
@Timeless0911 Timeless0911 deleted the js-api branch November 21, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants