Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: how to use eslint-loader in rspack #2353

Closed
AuglyXu opened this issue Mar 20, 2023 · 5 comments
Closed

[Feature Request]: how to use eslint-loader in rspack #2353

AuglyXu opened this issue Mar 20, 2023 · 5 comments
Labels
feat New feature or request

Comments

@AuglyXu
Copy link

AuglyXu commented Mar 20, 2023

What problem does this feature solve?

I want to use eslint-loader to warning in terminal, how can i use it?

What does the proposed API of configuration look like?

{
test: /.jsx/i
loader: 'eslint-loader'
}

@AuglyXu AuglyXu added the feat New feature or request label Mar 20, 2023
@Boshen
Copy link
Contributor

Boshen commented Mar 20, 2023

It is not recommended to run eslint inside webpack / rspack anymore. Run it in another build step, and also in lint-staged.

@hardfist
Copy link
Contributor

we will check whether we could make eslint-loader work now

@hardfist hardfist added this to the Backlog milestone Mar 20, 2023
@ScriptedAlchemy
Copy link
Contributor

be warned that transferring this much data between rust and js will be expensive and likely have an impact on build speed.
Echoing @Boshen - rather run yarn lint after the build process.
Anything that involves parsing in JS land will create bottlenecks.

If there were a rust based linter this would not be such a bottleneck.
If we used a packet buffer to push payloads from rust to a workerpool, this might preserve the parallelism of rust - however starting workers is not fast

@el-gringo
Copy link

Like this one ?
https://rslint.org/

Still in early stage development though.

@hardfist
Copy link
Contributor

hardfist commented Apr 24, 2023

eslint is supported in #2904, you can use eslint-rspack-plugin or eslint-loader to lint your project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants