Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking]: enable biome lint and format rules #7182

Open
16 of 54 tasks
SoonIter opened this issue Jul 16, 2024 · 2 comments
Open
16 of 54 tasks

[Tracking]: enable biome lint and format rules #7182

SoonIter opened this issue Jul 16, 2024 · 2 comments
Assignees
Labels
contrib: easy pr welcome tracking issue Category: A tracking issue for an RFC or an unstable feature.

Comments

@SoonIter
Copy link
Member

SoonIter commented Jul 16, 2024

What subject does this issue tracking?

Recommended rules https://biomejs.dev/linter/rules/#recommended-rules

Tasks

  1. team
    hardfist
@SoonIter SoonIter added the tracking issue Category: A tracking issue for an RFC or an unstable feature. label Jul 16, 2024
@SoonIter SoonIter self-assigned this Jul 17, 2024
@chenjiahan
Copy link
Member

We have enabled the organizeImports feature of Biome, but the git hooks only only run prettier before commit (see lint-staged.config.mjs).

After pushing code, the Biome may throw an error for organizeImports, which is a bit annoying. We should run Biome in the pre-commit hook to solve this.

image

https://github.com/web-infra-dev/rspack/actions/runs/9993447832/job/27620851849

@SoonIter
Copy link
Member Author

The rule that caused large changes has been opened, and the remaining rules can be opened in batches 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contrib: easy pr welcome tracking issue Category: A tracking issue for an RFC or an unstable feature.
Projects
None yet
Development

No branches or pull requests

2 participants