Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid role tests #14

Closed
Tracked by #3
cookiecrook opened this issue Mar 11, 2023 · 5 comments · Fixed by web-platform-tests/wpt#41323
Closed
Tracked by #3

grid role tests #14

cookiecrook opened this issue Mar 11, 2023 · 5 comments · Fixed by web-platform-tests/wpt#41323
Assignees

Comments

@cookiecrook
Copy link
Collaborator

cookiecrook commented Mar 11, 2023

E.g. an orphaned cell is not a cell, it needs to be in a table>row>cell context, etc.

follow-on from #8

@cookiecrook
Copy link
Collaborator Author

cookiecrook commented Apr 27, 2023

See html-aam/table-roles.html
Then add a new file wai-aria/role/grid-roles.html
Or add to the existing one.

@howard-e
Copy link

howard-e commented Aug 3, 2023

Hello @cookiecrook. I'm Howard with Bocoup, and would like to contribute to the testing of this (and other wai-aria related roles).

I've been looking through the other tests and discussions, and wondering if you could take a look at web-platform-tests/wpt#41323 to let me know if I'm on the right track here? I'd be happy to assign myself to some of the others if so (listbox, menu, etc)

@cookiecrook
Copy link
Collaborator Author

cookiecrook commented Aug 7, 2023

Hi Howard, for future reference, if you include "Closes (link to issue)" or "Resolves (link to issue)" in the PR description instead of "See (link to issue)", the Issue and PR records will be linked automatically. Please assign yourself to any issue you're working on. Thanks.

I have approved your PR with one editorial change to the naming of the contextual invalidation tests.

@howard-e
Copy link

Hi Howard, for future reference, if you include "Closes (link to issue)" or "Resolves (link to issue)" in the PR description instead of "See (link to issue)", the Issue and PR records will be linked automatically. Please assign yourself to any issue you're working on. Thanks.

Okay thanks

I have approved your PR with one editorial change to the naming of the contextual invalidation tests.

Thanks, I've committed the suggestion

@howard-e
Copy link

Filed the following browser bugs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants