Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid roles tests #19

Closed
Tracked by #3
cookiecrook opened this issue Mar 11, 2023 · 0 comments · Fixed by web-platform-tests/wpt#42013
Closed
Tracked by #3

invalid roles tests #19

cookiecrook opened this issue Mar 11, 2023 · 0 comments · Fixed by web-platform-tests/wpt#42013
Assignees

Comments

@cookiecrook
Copy link
Collaborator

cookiecrook commented Mar 11, 2023

invalid roles tests like role="foo"

Should probably also have attribute parsing tests in here too. No telling what people or frameworks will insert:

  • Various Unicode ranges, inc Emoji and zero space joiners.
  • Whitespace.
  • Punctuation.
  • Escape chars. URL encoded chars, etc.

Don't rely solely on the assignAndVerifyRolesByRoleNames convenience method for this one, as passing those values through the JS context will likely bypass some of the parsing tests (escaped/encoded chars for example) that we'd want to verify whether it came from JS assignment or markup.

Also, escape characters and joiners shouldn't behave differently in markup or via JS assignment (el.role or el.setAttribute()) but it'd be worth testing all three types of role re-assignment.

Follow-on from #8

Update: See a subsection of these in wai-aria/role/fallback-roles.html.

@cookiecrook cookiecrook self-assigned this Aug 7, 2023
@rahimabdi rahimabdi assigned rahimabdi and unassigned cookiecrook Aug 21, 2023
cookiecrook pushed a commit to web-platform-tests/wpt that referenced this issue Oct 13, 2023
Authored-by: Rahim Abdi <rahim_abdi@apple.com>

AccName invalid roles tests from web-platform-tests/interop-accessibility#19
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 26, 2023
… a=testonly

Automatic update from web-platform-tests
Update wai-aria/role/invalid-roles.html (#42013)

Authored-by: Rahim Abdi <rahim_abdi@apple.com>

AccName invalid roles tests from web-platform-tests/interop-accessibility#19
--

wpt-commits: 8be1d22ad586928f1db503cd76d018bf6848811f
wpt-pr: 42013
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Oct 27, 2023
… a=testonly

Automatic update from web-platform-tests
Update wai-aria/role/invalid-roles.html (#42013)

Authored-by: Rahim Abdi <rahim_abdi@apple.com>

AccName invalid roles tests from web-platform-tests/interop-accessibility#19
--

wpt-commits: 8be1d22ad586928f1db503cd76d018bf6848811f
wpt-pr: 42013
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 30, 2023
… a=testonly

Automatic update from web-platform-tests
Update wai-aria/role/invalid-roles.html (#42013)

Authored-by: Rahim Abdi <rahim_abdiapple.com>

AccName invalid roles tests from web-platform-tests/interop-accessibility#19
--

wpt-commits: 8be1d22ad586928f1db503cd76d018bf6848811f
wpt-pr: 42013

UltraBlame original commit: 7ba22fead5dbd7b59d4173c90b49cef8d8671695
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 30, 2023
… a=testonly

Automatic update from web-platform-tests
Update wai-aria/role/invalid-roles.html (#42013)

Authored-by: Rahim Abdi <rahim_abdiapple.com>

AccName invalid roles tests from web-platform-tests/interop-accessibility#19
--

wpt-commits: 8be1d22ad586928f1db503cd76d018bf6848811f
wpt-pr: 42013

UltraBlame original commit: 7ba22fead5dbd7b59d4173c90b49cef8d8671695
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 30, 2023
… a=testonly

Automatic update from web-platform-tests
Update wai-aria/role/invalid-roles.html (#42013)

Authored-by: Rahim Abdi <rahim_abdiapple.com>

AccName invalid roles tests from web-platform-tests/interop-accessibility#19
--

wpt-commits: 8be1d22ad586928f1db503cd76d018bf6848811f
wpt-pr: 42013

UltraBlame original commit: 7ba22fead5dbd7b59d4173c90b49cef8d8671695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants