-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interpolation color space for gradients #109
Comments
@sesse WDYT? |
The gradient-eval-* parts seem reasonable to me; they're fairly core functionality in the gradient spec. I don't fully understand the gradient-interpolation-method-* tests offhand, so I can't say much about them. |
@sesse They're about the new syntax that allows specifying the color-space used for interpolation in gradient functions, e.g. |
I agree with the rationale, and am happy to review a PR which adds a red fail if the syntax is unsupported (just an |
@lilles can you also review you're OK with including these tests in Interop 2022, since you're now reviewing some of the implementation? |
Yes. |
Making sure the tests fail without lab/lch support: https://chromium-review.googlesource.com/c/chromium/src/+/3902032 |
@jgraham can you chase someone for a Gecko position? |
Yeah, including these seems ok. |
It sounds like we are going to add these to Interop 2022. If for some reason we don't, adding for Interop 2023 would be good to do. We haven't filed an issue, however, since it's likely to go into 2022.... but typing out this comment to reserve the possibility of sticking in the 2023 pile for consideration if needed. |
Let's make this a proposal for next year. |
@nt1m since this isn't a focus area proposal, we should handle it like the flex/grid expansion, would you agree? |
Could go either way, this could perfectly be a new focus area given this is a separate spec (CSS images), but this does also fit into "Color spaces". I have no strong opinion here. |
There are 196 existing tests in "Color Spaces and Functions" and the suggestion is to add 10. That means the worst case reduction in score would be from 100% to 95%. We have support from representatives of all 3 engines on this thread, so I think we should bring this up in a future meeting to see if we can just label the tests and be done with it. In particular I'd want @jgraham to weigh in then. |
In the MDN short survey on CSS & HTML, "CSS color spaces and functions ( |
Thank you for proposing interpolation color space for gradients for inclusion in Interop 2023. We are pleased to let you know that this proposal was accepted as part of the Color Spaces and Functions focus area. You can follow the progress of this Focus Area on the Interop 2023 dashboard. For an overview of our process, see the proposal selection summary. Thank you for contributing to Interop 2023! Posted on behalf of the Interop team. |
** Test List **
** Rationale **
When I originally audited all the CSS Color tests in #20, I did consider adding these (see follow up comments), though it wasn't clear at the time that:
Things are more clear now:
I don't feel super strongly at this point in the year, I'm mostly filing this issue since to me this seemed more of an unintentional omission than intentional one.
WDYT? @emilio @argyleink
The text was updated successfully, but these errors were encountered: