-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove scroll-target-align-001.html & scroll-target-align-002.html #137
Comments
@nt1m I wonder why scroll-target-align-003.html is out of the candidates, it also has |
It was passing in WebKit so we didn't look at it closely, but yes, if it is for an optional feature, we should remove it from Interop 2022. The assert does suggest that the test is for the same feature. |
We discussed this in #162. There was broad agreement that we shouldn't include tests for optional behavior that some browser does not intend to implement. I took the action item to ask for confirmation on this issue and unlabel the issue. What I'll do is go ahead an unlabel them directly, and if there's no further feedback on this issue within a week, close this issue. |
Label removed from the 3 tests that have |
I think we can close this and re-open if there's any objection. |
Test List
Rationale
@nmoucht investigated, and found that this is testing an optional feature from the spec.
"If a page is navigated to a fragment that defines a target element (e.g. one that would be matched by :target, or the target of scrollIntoView()), and that element defines some snap positions, the user agent must snap to one of that element’s snap positions if its nearest scroll container is a scroll snap container. The user agent may also do this even when the scroll container has scroll-snap-type: none."
The tests are testing the last sentence which has "may" which suggests this is optional.
In fact, both tests have
<meta name="flags" content="may">
in the code.The text was updated successfully, but these errors were encountered: