From 7e58a49e306020dbc50c235ad093356152b1d72b Mon Sep 17 00:00:00 2001
From: Mason Freed <masonf@chromium.org>
Date: Fri, 1 Apr 2022 12:52:50 -0700
Subject: [PATCH] Migrate focus handling logic from <popup> to Element [popup
 7/7]

This moves the focus management stuff out of HTMLPopupElement and into
Element, to work with both <popup> and <div popup>.

With this CL, all of the WPTs now pass, with the exception of the one
for the anchor IDL property, which is an open issue [1].

[1] https://github.com/openui/open-ui/issues/382

Bug: 1307772
Change-Id: I0f475b52b1a14a910d267c7b681327f2e08976ac
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561291
Reviewed-by: David Baron <dbaron@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#988069}
---
 html/semantics/popups/popup-focus.tentative.html | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/html/semantics/popups/popup-focus.tentative.html b/html/semantics/popups/popup-focus.tentative.html
index 28dc0c90462fee..26b30b2865b575 100644
--- a/html/semantics/popups/popup-focus.tentative.html
+++ b/html/semantics/popups/popup-focus.tentative.html
@@ -11,13 +11,13 @@
   <button>first button</button>
 </div>
 
-<div popup=popup data-test='autofocus popup' autofocus class=should-be-focused>
+<div popup=popup data-test='autofocus popup' autofocus tabindex=-1 class=should-be-focused>
   <p>This is a popup</p>
 </div>
 
-<div popup=popup data-test='autofocus empty popup' autofocus class=should-be-focused></div>
+<div popup=popup data-test='autofocus empty popup' autofocus tabindex=-1 class=should-be-focused></div>
 
-<div popup=popup data-test='autofocus popup with button' autofocus class=should-be-focused>
+<div popup=popup data-test='autofocus popup with button' autofocus tabindex=-1 class=should-be-focused>
   <p>This is a popup</p>
   <button>button</button>
 </div>
@@ -38,7 +38,7 @@
   <button autofocus>second autofocus button</button>
 </div>
 
-<div popup=popup autofocus data-test='autofocus popup and multiple autofocus children' class=should-be-focused>
+<div popup=popup autofocus tabindex=-1 data-test='autofocus popup and multiple autofocus children' class=should-be-focused>
   <p>This is a popup</p>
   <button autofocus>autofocus button</button>
   <button autofocus>second autofocus button</button>
@@ -129,14 +129,14 @@
         button.remove();
       });
       popup.id = popupId;
-      button.setAttribute('popup', popupId);
+      button.setAttribute('triggerpopup', popupId);
       priorFocus.focus();
       button.click();
       assert_equals(document.activeElement, expectedFocusedElement, `${testName} activated by button.click()`);
 
       // Make sure we can directly focus the (already open) popup:
       popup.focus();
-      assert_equals(document.activeElement, popup.hasAttribute('delegatesfocus') ? expectedFocusedElement : popup, `${testName} directly focus with popup.focus()`);
+      assert_equals(document.activeElement, popup.hasAttribute('tabindex') ? popup : expectedFocusedElement, `${testName} directly focus with popup.focus()`);
       popup.hidePopup();
     }, "Popup focus test: " + testName);
   }