Merge pull request #117 from w3c/jgraham/marionette_postmessage_fixup

Fix marionette executor's use of postMessage events to get test results
web-platform-tests · Jun 3, 2015 · cabaf16 · cabaf16
2 parents 85935d4 + 029b0a5
commit cabaf16
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 14 deletions.
diff --git a/wptrunner/executors/testharness_marionette.js b/wptrunner/executors/testharness_marionette.js
@@ -5,23 +5,27 @@
 window.wrappedJSObject.timeout_multiplier = %(timeout_multiplier)d;
 window.wrappedJSObject.explicit_timeout = %(explicit_timeout)d;
 
-window.wrappedJSObject.addEventListener("message", function(event) {
-  var tests = event.data[0];
-  var status = event.data[1];
-  clearTimeout(timer);
-  marionetteScriptFinished({test:"%(url)s",
-                            tests: tests,
-                            status: status.status,
-                            message: status.message,
-                            stack: status.stack});
+window.wrappedJSObject.addEventListener("message", function listener(event) {
+    if (event.data.type != "complete") {
+        return;
+    }
+    window.wrappedJSObject.removeEventListener("message", listener);
+    clearTimeout(timer);
+    var tests = event.data.tests;
+    var status = event.data.status;
+    marionetteScriptFinished({test:"%(url)s",
+                              tests: tests,
+                              status: status.status,
+                              message: status.message,
+                              stack: status.stack});
 }, false);
 
 window.wrappedJSObject.win = window.open("%(abs_url)s", "%(window_id)s");
 
 var timer = null;
 if (%(timeout)s) {
-  timer = setTimeout(function() {
-    log("Timeout fired");
-    window.wrappedJSObject.win.timeout();
-  }, %(timeout)s);
+    timer = setTimeout(function() {
+        log("Timeout fired");
+        window.wrappedJSObject.win.timeout();
+    }, %(timeout)s);
 }
diff --git a/wptrunner/testharnessreport.js b/wptrunner/testharnessreport.js
@@ -3,7 +3,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 var props = {output:%(output)d,
-             explicit_timeout: true};
+             explicit_timeout: true,
+             message_events: ["completion"]};
 
 if (window.opener && "timeout_multiplier" in window.opener) {
     props["timeout_multiplier"] = window.opener.timeout_multiplier;