From d60e847522acc16d4a6aa86a071e28fde81e5e9c Mon Sep 17 00:00:00 2001
From: Momoko Sumida <momon@google.com>
Date: Fri, 7 Sep 2018 00:26:31 -0700
Subject: [PATCH] Fix :scope selector matching in the case of
 DocumentFragment/ShadowRoot

When used in querySelector and querySelectorAll, :scope should match
the element or the DocumentFragment/ShadowRoot the querySelector is
called on. However, WPT adeed in crrev.com/c/1158445 shows that :scope
matches nothing when querySelector is called on shadow root, while it
works fine when querySelector is called on true element.
This CL fixes :scope selector matching process so that :scope itself
matches DocumentFragment/ShadowRoot when querySelector is called on
DocumentFragment/ShadowRoot. Tests for DocumentFragment are also added
in this CL.

Link to the spec:
https://drafts.csswg.org/selectors-4/#the-scope-pseudo

Link to related issue:
https://github.com/w3c/csswg-drafts/issues/3016

Link to related CL:
crrev.com/c/1158445

Bug: 859692
Change-Id: If20fc4b122d93a553dc478be0ee958958340a34f
---
 css/selectors/scope-selector.html | 81 ++++++++++++++++++++++++++-----
 1 file changed, 69 insertions(+), 12 deletions(-)

diff --git a/css/selectors/scope-selector.html b/css/selectors/scope-selector.html
index bda0aed602aa691..3db6d1c0c5fd6b7 100644
--- a/css/selectors/scope-selector.html
+++ b/css/selectors/scope-selector.html
@@ -6,29 +6,86 @@
 <div id='shadowHost'></div>
 <script>
 'use strict'
-  const shadowRoot = shadowHost.attachShadow({mode:'open'})
-  shadowRoot.innerHTML = '<div class="div" id="external_div">Shadow Element<div id="nesteddiv">nested</div></div>';
+const shadowRoot = shadowHost.attachShadow({mode:'open'})
+var externalDiv = document.createElement("div");
+externalDiv.setAttribute('id', 'external');
+var nestedDiv = document.createElement("div");
+nestedDiv.setAttribute('id', 'nested');
+shadowRoot.appendChild(externalDiv);
+externalDiv.appendChild(nestedDiv);
 
-test(() => {
-  assert_equals(shadowRoot.firstChild.querySelectorAll(':scope >  div').length, 1, 'should get the number of direct children of external_div');
-  assert_equals(shadowRoot.firstChild.querySelector(':scope > div'), shadowRoot.getElementById("nesteddiv"), 'should get the first direct child of external_div');
-  assert_equals(shadowRoot.firstChild.querySelector(':scope > div').innerHTML, 'nested', 'should get the text in nesteddiv');
+const nestedShadowRoot = nestedDiv.attachShadow({mode:'open'})
+var shadowExternalDiv = document.createElement("div");
+shadowExternalDiv.setAttribute('id', 'shadow_external');
+var shadowNestedDiv = document.createElement("div");
+shadowNestedDiv.setAttribute('id', 'shadow_nested');
+nestedShadowRoot.appendChild(shadowExternalDiv);
+shadowExternalDiv.appendChild(shadowNestedDiv);
+
+test (() => {
+  assert_equals(shadowRoot.firstChild.querySelectorAll(':scope > div').length, 1, 'should get the number of direct children of externalDiv');
+  assert_equals(shadowRoot.firstChild.querySelector(':scope > div'), shadowRoot.getElementById("nested"), 'should get the first direct child of externalDiv');
+  assert_equals(shadowRoot.firstChild.querySelector(':scope > div'), shadowRoot.getElementById('nested'), 'should get nestedDiv');
 }, 'scope selector works in shadowRoot.firstChild')
 
-test(() => {
-  assert_equals(shadowRoot.querySelector(':scope > div'), shadowRoot.getElementById('external_div'), 'should get the direct child of shadowRoot');
+test (() => {
+  assert_equals(shadowRoot.querySelector(':scope > div'), shadowRoot.getElementById('external'), 'should get the direct child of shadowRoot');
   assert_equals(shadowRoot.querySelectorAll(':scope > div').length, 1, 'should get the number of direct div children of shadowRoot');
 }, 'Selecting direct child of shadow root with :scope should work')
 
-test(() => {
-  assert_equals(shadowRoot.querySelector(':scope div'), shadowRoot.getElementById('external_div'), 'should get the first div descendant of shadowRoot');
-  assert_equals(shadowRoot.querySelectorAll(':scope div').length, 2, 'should get the number of the div descendants of shadowRoot');
+test (() => {
+  assert_equals(shadowRoot.querySelector(':scope div'), shadowRoot.getElementById('external'), 'should get the first div descendant of shadowRoot');
+  assert_equals(shadowRoot.querySelectorAll(':scope div').length, 2, 'should get the number of the div descendants of shadowRoot, :scope div should not match for nestedShadow');
 }, 'Selecting descendants of shadow root with :scope should work')
 
+test (() => {
+  assert_equals(nestedShadowRoot.querySelector(':scope > div'), nestedShadowRoot.getElementById('shadow_external'), 'should get the direct child of nestedShadowRoot');
+  assert_equals(nestedShadowRoot.querySelectorAll(':scope > div').length, 1, 'should get the number of direct div children of nestedShadowRoot');
+}, 'Selecting direct child of nested shadow root with :scope should work')
+
+test (() => {
+  assert_equals(nestedShadowRoot.querySelector(':scope div'), nestedShadowRoot.getElementById('shadow_external'), 'should get the first div descendant of nestedShadowRoot');
+  assert_equals(nestedShadowRoot.querySelectorAll(':scope div').length, 2, 'should get the number of the div descendants of nestedShadowRoot');
+}, 'Selecting descendants of nested shadow root with :scope should work')
+
+test (() => {
+  assert_equals(shadowRoot.querySelectorAll(':scope /deep/ div').length, 4, 'should get the number of all the div elements regardless of shadow boundaries');
+  assert_equals(shadowHost.querySelectorAll(':scope /deep/ div').length, 4, 'should get the number of all the div elements regardless of shadow boundaries');
+}, 'Selecting descendants in and outside of shadow tree with :scope /deep/ should work')
+
+var documentFragment = document.createDocumentFragment();
+var external_div = document.createElement("div");
+external_div.setAttribute('id', 'external_div');
+var nested_div = document.createElement("div");
+nested_div.setAttribute('id', 'nested_div');
+documentFragment.appendChild(external_div);
+external_div.appendChild(nested_div);
+
+test(() => {
+  assert_equals(documentFragment.firstChild.querySelectorAll(':scope > div').length, 1, 'should get the number of direct children of external_div');
+  assert_equals(documentFragment.firstChild.querySelector(':scope > div'), documentFragment.getElementById("nested_div"), 'should get the first direct child of external_div');
+  assert_equals(documentFragment.firstChild.querySelector(':scope > div'), documentFragment.getElementById('nested_div'), 'should get the text in nesteddiv');
+}, 'scope selector works in documentFragment.firstChild')
+
+test(() => {
+  assert_equals(documentFragment.querySelector(':scope > div'), documentFragment.getElementById('external_div'), 'should get the direct child of DocumentFragment');
+  assert_equals(documentFragment.querySelectorAll(':scope > div').length, 1, 'should get the number of direct div children of DocumentFragment');
+}, 'Selecting direct child of document fragment with :scope should work')
+
+test(() => {
+  assert_equals(documentFragment.querySelector(':scope div'), documentFragment.getElementById('external_div'), 'should get the first div descendant of DocumentFragment');
+  assert_equals(documentFragment.querySelectorAll(':scope div').length, 2, 'should get the number of the div descendants of DocumentFragment');
+}, 'Selecting descendants of document fragment with :scope should work')
+
 test(() => {
   assert_equals(shadowRoot.firstChild.querySelector(':scope'), null, 'should return null');
+  assert_equals(shadowRoot.firstChild.querySelectorAll(':scope').length, 0, 'should return 0');
+
   assert_equals(shadowRoot.querySelector(':scope'), null, 'should return null');
   assert_equals(shadowRoot.querySelectorAll(':scope').length, 0, 'should return 0');
-}, 'querySelector() with ":scope" should return null, whether the context object is an element or a shadow root')
 
+  assert_equals(documentFragment.querySelector(':scope'), null, 'should return null');
+  assert_equals(documentFragment.querySelectorAll(':scope').length, 0, 'should return 0');
+
+}, 'querySelector() with ":scope" should return null, whether the context object is an element, a shadow root or a document fragment')
 </script>