Require virtualenv >= 20.0.11 to support virtualenv activation on Windows with py3

[svillar]

See pypa/virtualenv#1710 (comment)

[Hexcles]

This seems reasonable. AFAIK, virtualenv is a requirement that users need to install themselves: https://web-platform-tests.org/running-tests/from-local-system.html

On which setup do we get a virtualenv that's not recent enough? Azure?

[svillar]

This seems reasonable. AFAIK, virtualenv is a requirement that users need to install themselves: https://web-platform-tests.org/running-tests/from-local-system.html

On which setup do we get a virtualenv that's not recent enough? Azure?

You can reproduce this locally. When I found the bug there was no fix for the issue. It came quickly after reporting the issue to virtualenv package. I opened this to ensure that any user gets the proper version to be able to use python3 in windows to run wpt.

[stephenmcgruer]

So it looks like for Azure Pipelines we attempt to get virtualenv via ./tools/ci/azure/pip_install.yml, passing it parameters: packages: virtualenv.

For Safari, that results in us getting virtualenv-20.0.20:

pip --disable-pip-version-check install --upgrade virtualenv
========================== Starting Command Output ===========================
/bin/bash --noprofile --norc /Users/runner/runners/2.168.2/work/_temp/8201e078-1dd4-407e-a196-3b3a8e1686d6.sh
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Collecting virtualenv
  Downloading virtualenv-20.0.20-py2.py3-none-any.whl 

In a random log for Windows, however, I found that we already have virtualenv, and think it's of a valid version:

pip --disable-pip-version-check install --upgrade virtualenv
========================== Starting Command Output ===========================
"C:\windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "C:\Agent\_work\_temp\795dec64-e118-43a7-9d5f-c8f1a3dfe7ca.cmd""
Requirement already up-to-date: virtualenv in c:\python27\lib\site-packages

It's not clear to me where we would specify the version for virtualenv. Do we just need to add a requirements.txt for this? (./tools/ci/azure/pip_install.yml appears to not use a specific one, and grep -r virtualenv $(find tools/ -name requirements*) turns up nothing).

[stephenmcgruer]

cc @ziransun

[ziransun]

I take this is not an issue any more? Running py3 in windows (locally) seems fine for me with current codebase.