Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too much magic in WebDriver capabilities #48781

Open
gsnedders opened this issue Oct 23, 2024 · 0 comments
Open

Too much magic in WebDriver capabilities #48781

gsnedders opened this issue Oct 23, 2024 · 0 comments
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run

Comments

@gsnedders
Copy link
Member

gsnedders commented Oct 23, 2024 •
edited
Loading

We currently support passing capabilities in several ways: executor_kwargs, ExecutorBrowser.capabilities, along with some being passed from WebDriverProtocol.__init__.

With ExecutorBrowser.capabilities, it feels like it might make sense to get rid of what we set in WebDriverProtocol.__init__?

I still wonder if it makes more sense to move executor_kwargs to the Browser, and then call it later, and then we can have all the capabilities defined there. I think this is probably doable at this point?
@gsnedders gsnedders added infra wptrunner The automated test runner, commonly called through ./wpt run labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gsnedders