You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Historically @jgraham has cared a lot about making it easy to replicate what CI does locally, and often suggested moving things into scripts so that they can be easily tested locally.
For one, it fails to actually fetch the current gh-pages branch, because environment variables aren't set:
Maybe there will be some disagreement here, but it feels like a lot of these (especially the conditionals at the end!) should just be individual workflow steps.
The text was updated successfully, but these errors were encountered:
Historically @jgraham has cared a lot about making it easy to replicate what CI does locally, and often suggested moving things into scripts so that they can be easily tested locally.
For one, it fails to actually fetch the current
gh-pages
branch, because environment variables aren't set:wpt/tools/ci/website_build.sh
Line 13 in d2f2efe
And for another, it changes the global git config:
wpt/tools/ci/website_build.sh
Lines 29 to 30 in d2f2efe
Before finally failing when it tries to read a file that doesn't exist:
wpt/tools/ci/website_build.sh
Lines 16 to 27 in d2f2efe
Maybe there will be some disagreement here, but it feels like a lot of these (especially the conditionals at the end!) should just be individual workflow steps.
The text was updated successfully, but these errors were encountered: