Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make manifest path and expectation root independent #7959

Closed
lukebjerring opened this issue Oct 23, 2017 · 3 comments
Closed

Make manifest path and expectation root independent #7959

lukebjerring opened this issue Oct 23, 2017 · 3 comments

Comments

@lukebjerring
Copy link
Contributor

Currently, the MANIFEST.json is assumed to share a root with metadata (.inf) files. We should add support for passing in a different expectation root than the manifest path (--metadata-root).

This would allow us to build + utilize a root which pulls from the latest wpt.fyi results (re-using the expectation behaviour to detect regressions), for #7475

@lukebjerring lukebjerring self-assigned this Oct 23, 2017
@jgraham
Copy link
Contributor

jgraham commented Oct 23, 2017

Probably the right way to do this is to change metadata_root to expectation_root and manifest_path everywhere and for compat set manifest_path=os.path.join(metadata_root, "MANIFEST.json") and expectation_root=metadata_root if the manifest root is explicitly passed in in a command line argument (we can make the argument hidden so it's only legacy scripts that do this).

@alijuma
Copy link
Contributor

alijuma commented Feb 13, 2018

This has priority:roadmap. Is there any work planned for this quarter?

@gsnedders
Copy link
Member

fixed by #9676.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants