Editorial: cleanup some area opener/noopener tests #17025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out in #15188 (comment) it was a bit confusing (and wrong).
|
cc @ericlaw1979 |
|
@foolip #15188 (comment) onward still applies, so if this looks okay this can be landed. (The stability issue in Chrome remains if I comment out all |
|
@annevk seems like preexisting flakiness not caused by your changes, right? I'll review and admin merge. @KyleJu @lukebjerring can you use this as an example of flakiness to annotate in the ongoing metadata project? It's a good one because there's a mix of failures and passes in the same test. |
foolip
approved these changes
May 27, 2019
|
Yeah, the tests were already flaky in Chrome, this only serves to remove some confusing aspects of the tests that were not relevant. Thanks for merging! |
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
As pointed out in #15188 (comment) it was a bit confusing (and wrong).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #15188 (comment) it was a bit confusing (and wrong).