[mathml] Make math display values on non-MathML elements compute to flow #25483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 11, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2404789
branch
from
5f70cee to
554a211
Compare
This CL aligns with a recent resolution from the CSSWG: w3c/csswg-drafts#5385 (comment) This also ensures that LayoutObjectFactory::CreateMath always receives a MathML element. The new test fails when MathML Core (in particular LayoutNG) is disabled because math display values are not supported. Subtests fail when MathML Core is enabled because multiple display values are not supported. Bug: 1127222, 6606 Change-Id: Ica5558f221960d0f80609dfe0e56c029de7e9c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404789 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#806578}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2404789
branch
from
554a211 to
4c0af38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL aligns with a recent resolution from the CSSWG:
w3c/csswg-drafts#5385 (comment)
This also ensures that LayoutObjectFactory::CreateMath always receives
a MathML element.
The new test fails when MathML Core (in particular LayoutNG) is
disabled because math display values are not supported. Subtests fail
when MathML Core is enabled because multiple display values are not
supported.
Bug: 1127222, 6606
Change-Id: Ica5558f221960d0f80609dfe0e56c029de7e9c3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404789
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#806578}