From 68f1cfb189895e89cc1b64e8586675eff3b2e72e Mon Sep 17 00:00:00 2001 From: Ziran Sun Date: Wed, 21 Oct 2020 11:30:59 +0100 Subject: [PATCH 1/2] Python3: Remove xfail for wpt unit tests in PY3 Tests in test_wpt.py were marked as xfail due to virtualenv activation issue (https://github.com/pypa/virtualenv/issues/1710) This issue has now been solved. --- tools/wpt/tests/test_wpt.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/wpt/tests/test_wpt.py b/tools/wpt/tests/test_wpt.py index f0a9524c90a490..7057ba94ce1ad8 100644 --- a/tools/wpt/tests/test_wpt.py +++ b/tools/wpt/tests/test_wpt.py @@ -44,9 +44,6 @@ def get_persistent_manifest_path(): @pytest.fixture(scope="module", autouse=True) def init_manifest(): - # See https://github.com/pypa/virtualenv/issues/1710 - if sys.version_info[0] >= 3 and platform.system() == "Windows": - pytest.xfail(reason="virtualenv activation fails in Windows for python3") with pytest.raises(SystemExit) as excinfo: wpt.main(argv=["manifest", "--no-download", "--path", get_persistent_manifest_path()]) From ce0e4905b0156e9263c8998538ac27cf534f9e1f Mon Sep 17 00:00:00 2001 From: Ziran Sun Date: Wed, 21 Oct 2020 13:30:49 +0100 Subject: [PATCH 2/2] Remove unused import --- tools/wpt/tests/test_wpt.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/wpt/tests/test_wpt.py b/tools/wpt/tests/test_wpt.py index 7057ba94ce1ad8..02b611e378b887 100644 --- a/tools/wpt/tests/test_wpt.py +++ b/tools/wpt/tests/test_wpt.py @@ -1,6 +1,5 @@ import errno import os -import platform import shutil import socket import subprocess