-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to test replace before load #28480
Conversation
This comment has been minimized.
This comment has been minimized.
991534e
to
475d000
Compare
As Jake pointed out it shouldn't be necessary
475d000
to
31dccb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's what you documented in whatwg/html#6714, but I find the special cases for following hyperlinks and window.open()
a little jarring. I wonder if that's a necessary permanent behavior or something that we could adjust.
|
||
t.step_timeout(() => { | ||
asssert_equals(w.location.href, absoluteStartURL, "1 second after attempting to go back, it indeed went back"); | ||
}, 1000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and below: any way to shorten this? 1 second is a long time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to waiting for a posted message
I suspect window.open() could be changed, as could |
w.history.back(); | ||
|
||
t.step_timeout(() => { | ||
asssert_equals(w.location.href, absoluteStartURL, "1 second after attempting to go back, it indeed went back"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've got a couple of 'asssert_equals' typos throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh dear, the fact that these tests pass is troubling then. Thanks so much for the careful review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@natechapin I've sent you an invite for the wpt reviewers team so that next time your review is enough and you can also merge PRs. (It's write access, just the team isn't named as such.) |
Follows whatwg/html#6714.