Migrate focus handling logic from <popup> to Element [popup 7/7] #33437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 31, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3561291
branch
4 times, most recently
from
7849a43
to
f5adb93
Compare
This moves the focus management stuff out of HTMLPopupElement and into Element, to work with both <popup> and <div popup>. With this CL, all of the WPTs now pass, with the exception of the one for the anchor IDL property, which is an open issue [1]. [1] openui/open-ui#382 Bug: 1307772 Change-Id: I0f475b52b1a14a910d267c7b681327f2e08976ac Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561291 Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#988069}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3561291
branch
from
f5adb93
to
3f553bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the focus management stuff out of HTMLPopupElement and into
Element, to work with both <popup> and <div popup>.
With this CL, all of the WPTs now pass, with the exception of the one
for the anchor IDL property, which is an open issue [1].
[1] openui/open-ui#382
Bug: 1307772
Change-Id: I0f475b52b1a14a910d267c7b681327f2e08976ac
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561291
Reviewed-by: David Baron <dbaron@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#988069}