[Gecko Bug 1762088] Implement parsing / serialization for container{,-type,-name} CSS properties. #33463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perties. Two noteworthy details that may seem random otherwise: * Moving values around in nsStyleDisplay is needed so that the struct remains under the size limit that we have to avoid jumping allocator buckets. * All the test expectation churn is because tests depend on `container-type: size` parsing to run, and now they run. Tests for the relevant bits I implemented are passing, with the only exception of some `container-name-computed.html` failures which are w3c/csswg-drafts#7181. Safari agrees with us there. Other notes when looking at the spec and seeing how it matches the implementation: * `container` syntax doesn't match spec, but matches tests and sanity: w3c/csswg-drafts#7180 * `container-type` syntax doesn't _quite_ match spec, but matches tests and I think it's a spec bug since the definition for the missing keyword is gone: w3c/csswg-drafts#7179 Differential Revision: https://phabricator.services.mozilla.com/D142419 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1762088 gecko-commit: bdaf003569a7cd516ada250c6d73e5288a69b1ae gecko-reviewers: firefox-style-system-reviewers, layout-reviewers, boris
wpt-pr-bot
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two noteworthy details that may seem random otherwise:
Moving values around in nsStyleDisplay is needed so that the struct
remains under the size limit that we have to avoid jumping allocator
buckets.
All the test expectation churn is because tests depend on
container-type: sizeparsing to run, and now they run. Tests forthe relevant bits I implemented are passing, with the only exception
of some
container-name-computed.htmlfailures which are[css-contain] Do container names really need to be deduplicated, but only at computed-value time? w3c/csswg-drafts#7181. Safari agrees with
us there.
Other notes when looking at the spec and seeing how it matches the
implementation:
containersyntax doesn't match spec, but matches tests and sanity:[css-contain] container shorthand syntax is confusing. w3c/csswg-drafts#7180
container-typesyntax doesn't quite match spec, but matches testsand I think it's a spec bug since the definition for the missing
keyword is gone:
[css-contain] container-type: block-size referenced on the property syntax, but not defined w3c/csswg-drafts#7179
Differential Revision: https://phabricator.services.mozilla.com/D142419
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1762088
gecko-commit: bdaf003569a7cd516ada250c6d73e5288a69b1ae
gecko-reviewers: firefox-style-system-reviewers, layout-reviewers, boris