[@container] Change order of container shorthand #33565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 8, 2022
Adjust ConsumeContainerName so that we don't fail parsing completely whenever we encounter something unexpected. Since the initial value of container-type is an open issue [1], I'm leaving that as-is for now. Fixed: 1305128 [1] w3c/csswg-drafts#7202 Change-Id: I156a8da9a79d2108935958f3418b16aeb83d490e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3575938 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#990367}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3575938
branch
from
25526e2
to
30da816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust ConsumeContainerName so that we don't fail parsing completely
whenever we encounter something unexpected.
Since the initial value of container-type is an open issue [1],
I'm leaving that as-is for now.
Fixed: 1305128
[1] w3c/csswg-drafts#7202
Change-Id: I156a8da9a79d2108935958f3418b16aeb83d490e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3575938
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#990367}