Rename the popup IDL attribute to popUp, per resolution
#34487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 17, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3703470
branch
3 times, most recently
from
7d7867f
to
74f9247
Compare
See [1] for details, but `popup` as an IDL property is not web compatible. The community has decided to try `popUp` to see if perhaps that will be more compatible. [1] openui/open-ui#546 (comment) Bug: 1307772 Fixed: 1332480 Change-Id: I0b42c49a9c7b7fa7a6bf10c61443a8b52fb977bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3703470 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1017374}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3703470
branch
from
74f9247
to
54093e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See [1] for details, but
popupas an IDL property is not webcompatible. The community has decided to try
popUpto see if perhapsthat will be more compatible.
[1] openui/open-ui#546 (comment)
Bug: 1307772
Fixed: 1332480
Change-Id: I0b42c49a9c7b7fa7a6bf10c61443a8b52fb977bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3703470
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1017374}