Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the popup IDL attribute to popUp, per resolution #34487

Merged
merged 1 commit into from
Jun 23, 2022

Commits on Jun 23, 2022

  1. Rename the popup IDL attribute to popUp, per resolution

    See [1] for details, but `popup` as an IDL property is not web
    compatible. The community has decided to try `popUp` to see if perhaps
    that will be more compatible.
    
    [1] openui/open-ui#546 (comment)
    
    Bug: 1307772
    Fixed: 1332480
    
    Change-Id: I0b42c49a9c7b7fa7a6bf10c61443a8b52fb977bf
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3703470
    Reviewed-by: David Baron <dbaron@chromium.org>
    Commit-Queue: Mason Freed <masonf@chromium.org>
    Auto-Submit: Mason Freed <masonf@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1017374}
    Mason Freed authored and chromium-wpt-export-bot committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    54093e4 View commit details
    Browse the repository at this point in the history