Rename popup=async to popup=manual #34567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 23, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3722345
branch
4 times, most recently
from
5f52ba8
to
adfa2e8
Compare
Per the [1] resolution, we have decided to rename popup=async to popup=manual, since it is a) parallel to popup=auto, and b) easier to understand. [1] openui/open-ui#495 (comment) Bug: 1307772 Change-Id: I786f6332c2a7f9df4810aeedfd425e38579ea1b1 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3722345 Commit-Queue: Mason Freed <masonf@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1017762}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3722345
branch
from
adfa2e8
to
d54cdb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the [1] resolution, we have decided to rename popup=async to
popup=manual, since it is a) parallel to popup=auto, and b) easier
to understand.
[1] openui/open-ui#495 (comment)
Bug: 1307772
Change-Id: I786f6332c2a7f9df4810aeedfd425e38579ea1b1
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3722345
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1017762}