Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename popup=async to popup=manual #34567

Merged
merged 1 commit into from
Jun 24, 2022

Commits on Jun 24, 2022

  1. Rename popup=async to popup=manual

    Per the [1] resolution, we have decided to rename popup=async to
    popup=manual, since it is a) parallel to popup=auto, and b) easier
    to understand.
    
    [1] openui/open-ui#495 (comment)
    
    Bug: 1307772
    Change-Id: I786f6332c2a7f9df4810aeedfd425e38579ea1b1
    Cq-Do-Not-Cancel-Tryjobs: true
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3722345
    Commit-Queue: Mason Freed <masonf@chromium.org>
    Auto-Submit: Mason Freed <masonf@chromium.org>
    Reviewed-by: Joey Arhar <jarhar@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1017762}
    Mason Freed authored and chromium-wpt-export-bot committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    d54cdb6 View commit details
    Browse the repository at this point in the history