Rename showPopup->showPopUp and hidePopup->hidePopUp #34570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 23, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3717194
branch
2 times, most recently
from
3887a6b
to
0f73ceb
Compare
Per the resolution [1] and associated discussion [2] we need to rename showPopup to showPopUp, and hidePopup to hidePopUp. With the new scheme, the API is the "Pop up API", not the "Popup API". Note that this CL only changes the publicly-visible API from "popup" to "popUp", but leaves many internal references such as kPseudoPopupHidden instead of kPseudoPopUpHidden. crbug.com/1338587 tracks that follow-on work, which I'll do once this change is validated as being web compatible. [1] openui/open-ui#546 (comment) [2] openui/open-ui#549 Bug: 1307772 Bug: 1338587 Change-Id: Iaa28d4c1b7d526bb0b06c04eaec2fad5d0431746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3717194 Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1017676}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3717194
branch
from
0f73ceb
to
5ef26b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the resolution [1] and associated discussion [2] we need to
rename showPopup to showPopUp, and hidePopup to hidePopUp. With
the new scheme, the API is the "Pop up API", not the "Popup API".
Note that this CL only changes the publicly-visible API from
"popup" to "popUp", but leaves many internal references such as
kPseudoPopupHidden instead of kPseudoPopUpHidden. crbug.com/1338587
tracks that follow-on work, which I'll do once this change is
validated as being web compatible.
[1] openui/open-ui#546 (comment)
[2] openui/open-ui#549
Bug: 1307772
Bug: 1338587
Change-Id: Iaa28d4c1b7d526bb0b06c04eaec2fad5d0431746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3717194
Reviewed-by: David Baron <dbaron@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1017676}