Remove hover-triggered behaviors from the Pop-Up API #35536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 19, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3842343
branch
from
c2af70b
to
6cb1c0b
Compare
Rather than keeping all of this complexity in the codebase, based on the decision [1] to "punt" this behavior to V2 of the API, I'm going to remove it all. This CL can be reverted to bring it back. This CL mostly reverts the CLs below, but some functionality is left in place, such as the CSS time interpolation code. But for the most part, this reverts these CLs: 1. https://chromium-review.googlesource.com/c/chromium/src/+/3763422 2. https://chromium-review.googlesource.com/c/chromium/src/+/3760885 3. https://chromium-review.googlesource.com/c/chromium/src/+/3781406 4. https://chromium-review.googlesource.com/c/chromium/src/+/3812260 5. https://chromium-review.googlesource.com/c/chromium/src/+/3811136 [1] openui/open-ui#526 Bug: 1307772 Change-Id: I6c8e4c9d2cf1ef0d36df71767b26122f65ea5b5b Fixed: 1349910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842343 Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1037917}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3842343
branch
from
6cb1c0b
to
31d6815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than keeping all of this complexity in the codebase, based
on the decision [1] to "punt" this behavior to V2 of the API, I'm
going to remove it all. This CL can be reverted to bring it back.
This CL mostly reverts the CLs below, but some functionality is
left in place, such as the CSS time interpolation code. But for
the most part, this reverts these CLs:
[1] openui/open-ui#526
Bug: 1307772
Change-Id: I6c8e4c9d2cf1ef0d36df71767b26122f65ea5b5b
Fixed: 1349910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842343
Reviewed-by: David Baron <dbaron@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1037917}